linux-kernel - RE: [PATCH v2] powercap: Add Power Limit4 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL0PR11MB3363757AEC2CF48D77F68F89BB7F0@BL0PR11MB3363.namprd11.prod.outlook.com>
Date:   Thu, 16 Jul 2020 05:10:54 +0000
From:   "Pawnikar, Sumeet R" <sumeet.r.pawnikar@...el.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
CC:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>
Subject: RE: [PATCH v2] powercap: Add Power Limit4 support


> -----Original Message-----
> From: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Sent: Wednesday, July 15, 2020 5:44 AM
> To: Rafael J. Wysocki <rafael@...nel.org>; Pawnikar, Sumeet R
> <sumeet.r.pawnikar@...el.com>
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>; Zhang, Rui
> <rui.zhang@...el.com>; Linux PM <linux-pm@...r.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@...r.kernel.org>; Shevchenko, Andriy
> <andriy.shevchenko@...el.com>
> Subject: Re: [PATCH v2] powercap: Add Power Limit4 support
> 
> On Tue, 2020-07-14 at 15:21 +0200, Rafael J. Wysocki wrote:
> > >
> 
> [...]
> 
> > On Tue, Jul 14, 2020 at 10:22 AM Sumeet Pawnikar
> > <sumeet.r.pawnikar@...el.com> wrote:
> >
> > Srinivas, does the patch look good to you?
> 
> Some minor comments then Summet can add my
> 
> Reviewed-and-tested-by: Srinivas Pandruvada <
> srinivas.pandruvada@...ux.intel.com>
> 

Thanks Srinivas for testing this. 
I will address your below comment
and submit v3 with above tag. 

> > > ---
> > > Changes in v2:
> > >  - Addressed review comments from Rafael.
> > >  - Made the commit message more clearer.
> > >  - Updated powercap documentation.
> > > ---
> > >
> 
> [...]
> 
> > > 0,1).
> > > +Depending on different power zones, the Intel RAPL technology
> > > allows
> > > +one or multiple constraints like short term, long term and peak
> > > power,
> > > +with different time windows to be applied to each power zone.
> I think better to spell out that time window is not applicable to "peak power".
> Otherwise someone will send a bug report.
> 
> 
> [...]
> 
> > >  static int rapl_msr_probe(struct platform_device *pdev)  {
> > >         int ret;
> > > +       const struct x86_cpu_id *id =
> > > x86_match_cpu(pl4_support_ids);
> 
> To match coding style in this file:
> 	const struct x86_cpu_id *id = x86_match_cpu(pl4_support_ids);
>         int ret;
> 

Thanks for review.  

Regards,
Sumeet.

> > >         rapl_msr_priv.read_raw = rapl_msr_read_raw;
> 
> Thanks,
> Srinivas