linux-kernel - Re: [PATCH v12 2/2] phy: samsung-ufs: add UFS PHY driver for samsung SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200716051118.GB55478@vkoul-mobl>
Date:   Thu, 16 Jul 2020 10:41:18 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Alim Akhtar <alim.akhtar@...sung.com>
Cc:     robh+dt@...nel.org, krzk@...nel.org, kwmad.kim@...sung.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        kishon@...com
Subject: Re: [PATCH v12 2/2] phy: samsung-ufs: add UFS PHY driver for samsung
 SoC

Hi Alim,

On 16-07-20, 06:47, Alim Akhtar wrote:

> > > +static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy
> > > +*phy) {
> > > +	int ret = 0;
> > 
> > superfluous init, am sure I flagged it before as well
> > 
> Yes, you did, but 0-DAY CI kernel test gave warning [1], so I kept this as
> it is.
> [1] https://lkml.org/lkml/2020/7/3/81

But you moved away from return below to goto, so that is no longer
the case. First use of ret is for clk_prepare_enable() call below which
is not conditional hence this is superfluous. Earlier it was not as it was
conditional so required to be initialized

> 
> > > +
> > > +	phy->tx0_symbol_clk = devm_clk_get(phy->dev, "tx0_symbol_clk");
> > > +	if (IS_ERR(phy->tx0_symbol_clk)) {
> > > +		dev_err(phy->dev, "failed to get tx0_symbol_clk clock\n");
> > > +		goto out;
> > > +	}
> > > +
> > > +	phy->rx0_symbol_clk = devm_clk_get(phy->dev, "rx0_symbol_clk");
> > > +	if (IS_ERR(phy->rx0_symbol_clk)) {
> > > +		dev_err(phy->dev, "failed to get rx0_symbol_clk clock\n");
> > > +		goto out;
> > > +	}
> > > +
> > > +	phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
> > > +	if (IS_ERR(phy->rx0_symbol_clk)) {
> > > +		dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
> > > +		goto out;
> > > +	}
> > > +
> > > +	ret = clk_prepare_enable(phy->tx0_symbol_clk);
> > > +	if (ret) {
> > > +		dev_err(phy->dev, "%s: tx0_symbol_clk enable failed %d\n",
> > __func__, ret);
> > > +		goto out;
> > > +	}
-- 
~Vinod