linux-kernel - Re: linux-next: Tree for Jul 15 (drivers/phy/allwinner/phy-sun4i-usb.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200716062406.GG55478@vkoul-mobl>
Date:   Thu, 16 Jul 2020 11:54:06 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: linux-next: Tree for Jul 15
 (drivers/phy/allwinner/phy-sun4i-usb.c)

On 15-07-20, 08:18, Randy Dunlap wrote:
> On 7/15/20 1:05 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20200714:
> > 
> 
> on x86_64:
> # CONFIG_GPIOLIB is not set
> 
> ../drivers/phy/allwinner/phy-sun4i-usb.c: In function ‘sun4i_usb_phy0_get_id_det’:
> ../drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit declaration of function ‘gpiod_get_value_cansleep’; did you mean ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration]
>     return gpiod_get_value_cansleep(data->id_det_gpio);
>            ^~~~~~~~~~~~~~~~~~~~~~~~
>            gpio_get_value_cansleep
>   CC      fs/bad_inode.o
> ../drivers/phy/allwinner/phy-sun4i-usb.c: In function ‘sun4i_usb_phy_probe’:
> ../drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit declaration of function ‘devm_gpiod_get_optional’; did you mean ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration]
>   data->id_det_gpio = devm_gpiod_get_optional(dev, "usb0_id_det",
>                       ^~~~~~~~~~~~~~~~~~~~~~~
>                       devm_clk_get_optional
> ../drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: ‘GPIOD_IN’ undeclared (first use in this function); did you mean ‘GPIOF_IN’?
>            GPIOD_IN);
>            ^~~~~~~~
>            GPIOF_IN
> ../drivers/phy/allwinner/phy-sun4i-usb.c:708:11: note: each undeclared identifier is reported only once for each function it appears in
> ../drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit declaration of function ‘gpiod_to_irq’; did you mean ‘gpio_to_irq’? [-Werror=implicit-function-declaration]
>   data->id_det_irq = gpiod_to_irq(data->id_det_gpio);
>                      ^~~~~~~~~~~~
>                      gpio_to_irq
> 
> 
> Full randconfig file is attached.

Thanks Randy for the report, it is fixed by adding the right gpio
header, sending a patch now

-- 
~Vinod