linux-kernel - Re: [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jul 2020 08:29:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bhanu Prakash Maiya <bhanumaiya@...omium.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Lee Jones <lee.jones@...aro.org>,
        Furquan Shaikh <furquan@...omium.org>,
        Raul E Rangel <rrangel@...omium.org>,
        Eric Peers <epeers@...gle.com>,
        Duncan Laurie <dlaurie@...gle.com>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart
 transport layer

On Thu, Jul 16, 2020 at 08:28:07AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 15, 2020 at 10:14:29PM -0700, Bhanu Prakash Maiya wrote:
> > From: Bhanu Prakash Maiya <bhanumaiya@...omium.org>
> > 
> > This patch enables uart transport layer for cros_ec framework.
> > The cros-ec-uart binds with EC device working on uart transport to
> > send request and receive response.
> > 
> > Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@...omium.org>
> 
> If this really is a "UART", why is this not a serial/tty driver?

Ah, it's a serdev driver.  that wasn't obvious.

Please write a much better changelog saying what this driver is and why
it needs to be the type that it is, as I totally missed that from these
2 sentences.

thanks,

greg k-h