linux-kernel - Re: [PATCH] phy: sun4i-usb: explicitly include gpio/consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Jul 2020 14:54:50 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] phy: sun4i-usb: explicitly include gpio/consumer.h

On Thu, Jul 16, 2020 at 2:24 PM Vinod Koul <vkoul@...nel.org> wrote:
>
> Driver uses GPIO functions but doesn't include the header explcitly. Add
> that to fix build errors when GPIOLIB is disabled.
>
> drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit
> declaration of function ‘gpiod_get_value_cansleep’; did you mean
> ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration]
> drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit
> declaration of function ‘devm_gpiod_get_optional’; did you mean
> ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration]
> drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: ‘GPIOD_IN’
> undeclared (first use in this function); did you mean ‘GPIOF_IN’?
> drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit
> declaration of function ‘gpiod_to_irq’; did you mean ‘gpio_to_irq’?
> [-Werror=implicit-function-declaration]
>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>

Maybe add

Fixes: ba4bdc9e1dc0 ("PHY: sunxi: Add driver for sunxi usb phy") ?

Though it probably doesn't apply cleanly on the oldest stable
kernel due to the extcon-provider header.

Either way,

Acked-by: Chen-Yu Tsai <wens@...e.org>