linux-kernel - Re: [PATCH V6 6/6] clk: imx6sl: Fix build warning reported by kernel test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159486121748.1987609.16422613903444902156@swboyd.mtv.corp.google.com>
Date:   Wed, 15 Jul 2020 18:00:17 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Anson Huang <Anson.Huang@....com>,
        Georg.Waibel@...demann-group.com, abel.vesa@....com,
        aisheng.dong@....com, andrew.smirnov@...il.com, chen.fang@....com,
        daniel.baluta@....com, festevam@...il.com, fugang.duan@....com,
        georg.waibel@...demann-group.de, horia.geanta@....com,
        j.remmet@...tec.de, kernel@...gutronix.de,
        laurent.pinchart@...asonboard.com,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mturquette@...libre.com,
        peng.fan@....com, s.hauer@...gutronix.de, sfr@...b.auug.org.au,
        shawnguo@...nel.org, yuehaibing@...wei.com
Cc:     Linux-imx@....com
Subject: Re: [PATCH V6 6/6] clk: imx6sl: Fix build warning reported by kernel test robot

Quoting Anson Huang (2020-07-06 22:09:39)
> Use readl_relaxed() instead of __raw_readl(), and use BIT(x)
> instead of (1 << X) to fix below build warning reported by kernel
> test robot:
> 
> drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit
> value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
>      while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK))
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Reported-by: kernel test robot <lkp@...el.com>
> ---

The subject is poor. Please improve it so that it summarizes the change
instead of the reaction to a warning from a robot.

> New patch.
> ---
>  drivers/clk/imx/clk-imx6sl.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 

This should come earlier in the series too so that the build warning
doesn't come out before this patch is applied.