linux-kernel - Re: [PATCH] rtc: max77686: Do not allow interrupt to fire before system resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159489082551.8339.14774575575042463785.b4-ty@bootlin.com>
Date:   Thu, 16 Jul 2020 11:15:24 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Lee Jones <lee.jones@...aro.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH] rtc: max77686: Do not allow interrupt to fire before system resume

On Mon, 15 Jun 2020 18:14:55 +0200, Krzysztof Kozlowski wrote:
> The rtc-max77686 device shares the main interrupt line with parent MFD
> device (max77686 driver).  During the system suspend, the parent MFD
> device disables this IRQ to prevent an early event happening before
> resuming I2C bus controller.
> 
> The same should be done by rtc-max77686 driver because otherwise the
> interrupt handler max77686_rtc_alarm_irq() will be called before its
> resume function (max77686_rtc_resume()).  Such issue is not fatal but
> disabling shared IRQ by all users ensures correct behavior.

Applied, thanks!

[1/1] rtc: max77686: Do not allow interrupt to fire before system resume
      commit: d8f090dbeafdcc3d30761aa0062f19d1adf9ef08

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@...tlin.com>