lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jul 2020 12:03:44 +0100 From: Qais Yousef <qais.yousef@....com> To: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org> Cc: Doug Anderson <dianders@...omium.org>, Qais Yousef <qais.yousef@....com>, Jonathan Corbet <corbet@....net>, Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>, Iurii Zaikin <yzaikin@...gle.com>, Quentin Perret <qperret@...gle.com>, Valentin Schneider <valentin.schneider@....com>, Patrick Bellasi <patrick.bellasi@...bug.net>, Pavan Kondeti <pkondeti@...eaurora.org>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org Subject: [PATCH v7 0/3] sched/uclamp: new sysctl for default RT boost value Changes in v7: * Rebase on top of tip/sched/core * Hold task_rq_lock() instead of using RCU. * Better document that changes to p->uclamp_ require task_rq_lock() * Remove smp_{wr}mp() * Hold the the tasklist_lock with smp_mp__after_spinlock() * Add patch 3 which addresses a splat I've seen while testing. static_branch_enable() in __setscheduler_uclamp() was causing it. Remove the call outside of the critical section to fix it. *** v6 cover-letter *** This series introduces a new sysctl_sched_uclamp_util_min_rt_default to control at runtime the default boost value of RT tasks. Full rationale is in patch 1 commit message. v6 has changed the approach taken in v5 [1] and earlier by moving away from the lazy update approach that touched the fast path to a synchronous one that is performed when the write to the procfs entry is done. for_each_process_thread() is used to update all existing RT tasks now. And to handle the race with a concurrent fork() we introduce sched_post_fork() in _do_fork() to ensure a concurrently forked RT tasks gets the right update. To ensure the race condition is handled correctly, I wrote this small (simple!) test program: https://github.com/qais-yousef/uclamp_test.git And ran it on 4core x86 system and 8core big.LITTLE juno-r2 system. >From juno-r2 run, 10 iterations each run: Without sched_post_fork() # ./run.sh pid 3105 has 336 but default should be 337 pid 13162 has 336 but default should be 337 pid 23256 has 338 but default should be 339 All forked RT tasks had the correct uclamp.min pid 10638 has 334 but default should be 335 All forked RT tasks had the correct uclamp.min pid 30683 has 335 but default should be 336 pid 8247 has 336 but default should be 337 pid 18170 has 1024 but default should be 334 pid 28274 has 336 but default should be 337 With sched_post_fork() # ./run.sh All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min All forked RT tasks had the correct uclamp.min Thanks -- Qais Yousef [1] https://lore.kernel.org/lkml/20200511154053.7822-1-qais.yousef@arm.com/ CC: Jonathan Corbet <corbet@....net> CC: Juri Lelli <juri.lelli@...hat.com> CC: Vincent Guittot <vincent.guittot@...aro.org> CC: Dietmar Eggemann <dietmar.eggemann@....com> CC: Steven Rostedt <rostedt@...dmis.org> CC: Ben Segall <bsegall@...gle.com> CC: Mel Gorman <mgorman@...e.de> CC: Luis Chamberlain <mcgrof@...nel.org> CC: Kees Cook <keescook@...omium.org> CC: Iurii Zaikin <yzaikin@...gle.com> CC: Quentin Perret <qperret@...gle.com> CC: Valentin Schneider <valentin.schneider@....com> CC: Patrick Bellasi <patrick.bellasi@...bug.net> CC: Pavan Kondeti <pkondeti@...eaurora.org> CC: linux-doc@...r.kernel.org CC: linux-kernel@...r.kernel.org CC: linux-fsdevel@...r.kernel.org Qais Yousef (3): sched/uclamp: Add a new sysctl to control RT default boost value Documentation/sysctl: Document uclamp sysctl knobs sched/uclamp: Fix a deadlock when enabling uclamp static key Documentation/admin-guide/sysctl/kernel.rst | 54 +++++++ include/linux/sched.h | 10 +- include/linux/sched/sysctl.h | 1 + include/linux/sched/task.h | 1 + kernel/fork.c | 1 + kernel/sched/core.c | 149 ++++++++++++++++++-- kernel/sysctl.c | 7 + 7 files changed, 208 insertions(+), 15 deletions(-) -- 2.17.1
Powered by blists - more mailing lists