linux-kernel - Re: ioremap and dma cleanups and fixes for superh (2nd resend)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6100edfb-34b4-6828-5528-92aa8e8d214f@physik.fu-berlin.de>
Date:   Thu, 16 Jul 2020 13:30:04 +0200
From:   John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Rich Felker <dalias@...c.org>, Christoph Hellwig <hch@....de>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: ioremap and dma cleanups and fixes for superh (2nd resend)

On 7/15/20 6:18 PM, John Paul Adrian Glaubitz wrote:
> Found the culprit:
> 
> c5b27a889da92f4a969d61df77bd4f79ffce57c9 is the first bad commit
> commit c5b27a889da92f4a969d61df77bd4f79ffce57c9
> Author: Peter Zijlstra <peterz@...radead.org>
> Date:   Tue Sep 4 14:45:04 2018 +0200
> 
>     sh/tlb: Convert SH to generic mmu_gather
>     
>     Generic mmu_gather provides everything SH needs (range tracking and
>     cache coherency).
>     
>     No change in behavior intended.
>     
>     Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
>     Cc: Andrew Morton <akpm@...ux-foundation.org>
>     Cc: Andy Lutomirski <luto@...nel.org>
>     Cc: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
>     Cc: Borislav Petkov <bp@...en8.de>
>     Cc: Dave Hansen <dave.hansen@...ux.intel.com>
>     Cc: H. Peter Anvin <hpa@...or.com>
>     Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>     Cc: Nick Piggin <npiggin@...il.com>
>     Cc: Peter Zijlstra <peterz@...radead.org>
>     Cc: Rich Felker <dalias@...c.org>
>     Cc: Rik van Riel <riel@...riel.com>
>     Cc: Thomas Gleixner <tglx@...utronix.de>
>     Cc: Will Deacon <will.deacon@....com>
>     Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>     Signed-off-by: Ingo Molnar <mingo@...nel.org>
> 
>  arch/sh/include/asm/pgalloc.h |   9 +++
>  arch/sh/include/asm/tlb.h     | 130 +-----------------------------------------
>  2 files changed, 10 insertions(+), 129 deletions(-)
> 
> CC'ing the author (Peter Zijlstra <peterz@...radead.org>).
This is fixed by [1]:

sh/tlb: Fix PGTABLE_LEVELS > 2

Geert reported that his SH7722-based Migo-R board failed to boot after
commit:

  c5b27a889da9 ("sh/tlb: Convert SH to generic mmu_gather")

That commit fell victim to copying the wrong pattern --
__pmd_free_tlb() used to be implemented with pmd_free().

Fixes: c5b27a889da9 ("sh/tlb: Convert SH to generic mmu_gather")
Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>

I'm now running a current kernel on my SH-7785LCR with no issues.

Adrian

> [1] https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=mm/tlb&id=1f19a4bf8dcb42efc278940fb81c288c346b3eda

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@...ian.org
`. `'   Freie Universitaet Berlin - glaubitz@...sik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913