linux-kernel - Re: [PATCH] crypto/x86: Remove include/asm/inst.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jul 2020 21:54:49 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Uros Bizjak <ubizjak@...il.com>
Cc:     linux-crypto@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] crypto/x86: Remove include/asm/inst.h

On Thu, Jul 09, 2020 at 05:08:57PM +0200, Uros Bizjak wrote:
> Current minimum required version of binutils is 2.23,
> which supports PSHUFB, PCLMULQDQ, PEXTRD, AESKEYGENASSIST,
> AESIMC, AESENC, AESENCLAST, AESDEC, AESDECLAST and MOVQ
> instruction mnemonics.
> 
> Substitute macros from include/asm/inst.h with a proper
> instruction mnemonics in various assmbly files from
> x86/crypto directory, and remove now unneeded file.
> 
> The patch was tested by calculating and comparing sha256sum
> hashes of stripped object files before and after the patch,
> to be sure that executable code didn't change.
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> CC: Herbert Xu <herbert@...dor.apana.org.au>
> CC: "David S. Miller" <davem@...emloft.net>
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Ingo Molnar <mingo@...hat.com>
> CC: Borislav Petkov <bp@...en8.de>
> CC: "H. Peter Anvin" <hpa@...or.com>
> ---
>  arch/x86/crypto/aes_ctrby8_avx-x86_64.S   |   1 -
>  arch/x86/crypto/aesni-intel_asm.S         | 733 +++++++++++-----------
>  arch/x86/crypto/aesni-intel_avx-x86_64.S  |   1 -
>  arch/x86/crypto/crc32-pclmul_asm.S        |  47 +-
>  arch/x86/crypto/crc32c-pcl-intel-asm_64.S |   5 +-
>  arch/x86/crypto/ghash-clmulni-intel_asm.S |  17 +-
>  arch/x86/include/asm/inst.h               | 311 ---------
>  7 files changed, 399 insertions(+), 716 deletions(-)
>  delete mode 100644 arch/x86/include/asm/inst.h

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt