linux-kernel - Re: [PATCH V4 0/7] Tegra XUSB charger detect support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200716124809.GC535268@ulmo>
Date:   Thu, 16 Jul 2020 14:48:09 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>
Cc:     Nagarjuna Kristam <nkristam@...dia.com>, jonathanh@...dia.com,
        mark.rutland@....com, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 0/7] Tegra XUSB charger detect support

On Fri, Jun 26, 2020 at 03:48:55PM +0530, Nagarjuna Kristam wrote:
> This patch series adds charger detect support on XUSB hardware used in
> Tegra210 and Tegra186 SoCs.
> 
> This patchset is composed with :
>  - dt bindings of XUSB Pad Controller
>  - Tegra XUSB device mode driver to add vbus_draw support 
>  - Tegra PHY driver for charger detect support
> 
> Tests done:
>  - Connect USB cable from ubuntu host to micro-B port of DUT to detect
>    SDP_TYPE charger
>  - Connect USB cable from external powered USB hub(which inturn connects
>    to ubuntu host) to micro-B port of DUT to detect CDP_TYPE charger.
>  - Connect USB cable from USB charger to micro-B port of DUT to detect
>    DCP_TYPE charger.
> DUT: Jetson-tx1, Jetson tx2.
> 
> V4:
>  - Added ACKed-by details for PHY driver.
>  - Used BIT macro instead of (1 << index) usage as suggested by Chunfeng Yun.
> V3:
>  - Added ACKed-by details for PHY driver and DT changes.
>  - Functions and its arguments are aligned.
>  - Tabs are used for alignment of MACRO's
>  - For vbus_draw USDC callback, usb_phy set_power error is propogated.
>  - Fixed various comments given by thierry.
> V2:
>  - Added ACKed-by details for DT patches.
>  - All patches rebased.
> 
> Nagarjuna Kristam (7):
>   dt-bindings: phy: tegra-xusb: Add charger-detect property
>   phy: tegra: xusb: Add support for UTMI pad power control
>   phy: tegra: xusb: Add USB2 pad power control support for Tegra210
>   phy: tegra: xusb: Add soc ops API to enable UTMI PAD protection
>   phy: tegra: xusb: Add support for charger detect
>   phy: tegra: xusb: Enable charger detect for Tegra186
>   phy: tegra: xusb: Enable charger detect for Tegra210
> 
>  .../bindings/phy/nvidia,tegra124-xusb-padctl.txt   |   4 +
>  drivers/phy/tegra/Makefile                         |   2 +-
>  drivers/phy/tegra/cd.c                             | 283 +++++++++++++++++++++
>  drivers/phy/tegra/xusb-tegra186.c                  |  92 +++++--
>  drivers/phy/tegra/xusb-tegra210.c                  | 223 +++++++++++-----
>  drivers/phy/tegra/xusb.c                           |  80 ++++++
>  drivers/phy/tegra/xusb.h                           |  22 ++
>  7 files changed, 621 insertions(+), 85 deletions(-)
>  create mode 100644 drivers/phy/tegra/cd.c

Hi Kishon, Vinod,

did you have any further comments on this series or is it good to go
into v5.9?

Thanks,
Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)