linux-kernel - Re: [PATCH 08/14] spi: spi-pl022: Provide missing struct attribute/function param docs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbFWy9wkMbegtL+nKG2RNvBADuxCxDRJTP8f0QGgUHZ3A@mail.gmail.com>
Date:   Thu, 16 Jul 2020 15:59:19 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Sachin Verma <sachin.verma@...com>
Subject: Re: [PATCH 08/14] spi: spi-pl022: Provide missing struct
 attribute/function param docs

On Wed, Jul 15, 2020 at 5:06 PM Lee Jones <lee.jones@...aro.org> wrote:

> Also demote non-worthy kerneldoc headers to standard comment blocks.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/spi/spi-pl022.c:304: warning: cannot understand function prototype: 'enum ssp_writing '
>  drivers/spi/spi-pl022.c:330: warning: Function parameter or member 'loopback' not described in 'vendor_data'
>  drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'rx_lev_trig' not described in 'pl022'
>  drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'tx_lev_trig' not described in 'pl022'
>  drivers/spi/spi-pl022.c:398: warning: Function parameter or member 'dma_running' not described in 'pl022'
>  drivers/spi/spi-pl022.c:670: warning: Function parameter or member 'pl022' not described in 'readwriter'
>  drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'irq' not described in 'pl022_interrupt_handler'
>  drivers/spi/spi-pl022.c:1250: warning: Function parameter or member 'dev_id' not described in 'pl022_interrupt_handler'
>  drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'pl022' not described in 'set_up_next_transfer'
>  drivers/spi/spi-pl022.c:1343: warning: Function parameter or member 'transfer' not described in 'set_up_next_transfer'
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Sachin Verma <sachin.verma@...com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij