linux-kernel - Re: [PATCH 2/3] ARM: dts: allwinner: convert gpio.h to sunxi-gpio.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200717160840.goez5i5nov7twxfx@gilmour.lan>
Date:   Fri, 17 Jul 2020 18:08:40 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Frank Lee <frank@...winnertech.com>
Cc:     robh+dt@...nel.org, wens@...e.org, tiny.windzz@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: allwinner: convert gpio.h to sunxi-gpio.h

On Wed, Jul 15, 2020 at 07:55:07PM +0800, Frank Lee wrote:
> From: Yangtao Li <frank@...winnertech.com>
> 
> Use names instead of numbers to describe GPIO. We clean arm64 first.
> Since H5 uses the DTS file in arm directory, we need to modify the
> header file in advance.
> 
> Signed-off-by: Yangtao Li <frank@...winnertech.com>
> 
> ---
>  arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi  | 2 +-
>  arch/arm/boot/dts/sunxi-libretech-all-h3-cc.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi b/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
> index fc67e30fe212..93f9653b43f4 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5-emlid-neutis.dtsi
> @@ -7,7 +7,7 @@
>  
>  #include "sunxi-common-regulators.dtsi"
>  
> -#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/gpio/sunxi-gpio.h>

I think we should have both. The gpio.h header is supposed to be for the
generic defines, while ours would be for the one specific to the
allwinner SoCs (just like it's being done for the GIC vs generic
interrupt flags)

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)