linux-kernel - Re: [PATCH net 3/3] net: bcmgenet: restore HFB filters on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9706ae96-65cf-a84d-3879-497358bed73f@gmail.com>
Date:   Fri, 17 Jul 2020 09:34:17 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/3] net: bcmgenet: restore HFB filters on resume



On 7/16/2020 4:38 PM, Doug Berger wrote:
> The Hardware Filter Block RAM may not be preserved when the GENET
> block is reset during a deep sleep, so it is not sufficient to
> only backup and restore the enables.
> 
> This commit clears out the HFB block and reprograms the rxnfc
> rules when the system resumes from a suspended state. To support
> this the bcmgenet_hfb_create_rxnfc_filter() function is modified
> to access the register space directly so that it can't fail due
> to memory allocation issues.
> 
> Fixes: f50932cca632 ("net: bcmgenet: add WAKE_FILTER support")
> Signed-off-by: Doug Berger <opendmb@...il.com>
Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian