linux-kernel - Re: [PATCH 5/7] usb: bdc: driver runs out of buffer descriptors on large ADB transfers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bc7603c-0e1f-762f-0d67-1c817c03c5ca@gmail.com>
Date:   Fri, 17 Jul 2020 09:58:05 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Al Cooper <alcooperx@...il.com>, linux-kernel@...r.kernel.org
Cc:     devicetree@...r.kernel.org, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Sasi Kumar <sasi.kumar@...adcom.com>
Subject: Re: [PATCH 5/7] usb: bdc: driver runs out of buffer descriptors on
 large ADB transfers



On 7/17/2020 8:23 AM, Al Cooper wrote:
> Version v1.0.40 of the Android host ADB software increased maximum
> transfer sizes from 256K to 1M. Since the STB ADB gadget driver
> requests only 16K at a time, the BDC driver ran out of buffer
> descriptors (BDs) if the queuing happens faster than the incoming
> 16K transfers. This issue is fixed by doubling the number of BDs
> that can be queued so that the entire 1M request can be queued
> without running out of buffers.
> 
> Signed-off-by: Al Cooper <alcooperx@...il.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

You can certainly remove my SoB here, since you are carrying your own
patch, thanks!
-- 
Florian