linux-kernel - Re: [PATCH 4.14 105/136] usb/ehci-platform: Set PM runtime as active on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200717171618.GQ2722994@sasha-vm>
Date:   Fri, 17 Jul 2020 13:16:18 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Qais Yousef <qais.yousef@....com>
Cc:     Eugeniu Rosca <erosca@...adit-jv.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, linux-pm@...r.kernel.org,
        Tony Prisk <linux@...sktech.co.nz>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Oliver Neukum <oneukum@...e.de>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>,
        Dirk Behme <dirk.behme@...bosch.com>,
        Eugeniu Rosca <roscaeugeniu@...il.com>
Subject: Re: [PATCH 4.14 105/136] usb/ehci-platform: Set PM runtime as active
 on resume

On Fri, Jul 17, 2020 at 05:17:23PM +0100, Qais Yousef wrote:
>Hi Eugeniu
>
>On 07/09/20 09:00, Eugeniu Rosca wrote:
>> Hello everyone,
>>
>> Cc: linux-renesas-soc
>> Cc: linux-pm
>
>[...]
>
>> After integrating v4.14.186 commit 5410d158ca2a50 ("usb/ehci-platform:
>> Set PM runtime as active on resume") into downstream v4.14.x, we started
>> to consistently experience below panic [1] on every second s2ram of
>> R-Car H3 Salvator-X Renesas reference board.
>>
>> After some investigations, we concluded the following:
>>  - the issue does not exist in vanilla v5.8-rc4+
>>  - [bisecting shows that] the panic on v4.14.186 is caused by the lack
>>    of v5.6-rc1 commit 987351e1ea7772 ("phy: core: Add consumer device
>>    link support"). Getting evidence for that is easy. Reverting
>>    987351e1ea7772 in vanilla leads to a similar backtrace [2].
>>
>> Questions:
>>  - Backporting 987351e1ea7772 ("phy: core: Add consumer device
>>    link support") to v4.14.187 looks challenging enough, so probably not
>>    worth it. Anybody to contradict this?
>>  - Assuming no plans to backport the missing mainline commit to v4.14.x,
>>    should the following three v4.14.186 commits be reverted on v4.14.x?
>>    * baef809ea497a4 ("usb/ohci-platform: Fix a warning when hibernating")
>>    * 9f33eff4958885 ("usb/xhci-plat: Set PM runtime as active on resume")
>>    * 5410d158ca2a50 ("usb/ehci-platform: Set PM runtime as active on resume")
>
>Thanks for investigating this.
>
>Alan, Greg, do you have any ideas?

I've reverted these 3 commits from 5.4 and earlier, thank you for
investigating this issue.

-- 
Thanks,
Sasha