linux-kernel - Re: [PATCH 06/25] Documentation: usbstring: usb_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c4a651b-06ca-d8fd-dbcf-546250316f16@infradead.org>
Date:   Fri, 17 Jul 2020 12:36:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Daniel W. S. Almeida" <dwlsalmeida@...il.com>, corbet@....net,
        mchehab@...nel.org
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/25] Documentation: usbstring: usb_validate_langid: Fix
 sphinx warnings

On 7/17/20 11:56 AM, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
> 
> Fix the following warnings:
> 
> warning: Function parameter or member 'langid' not described in
> 'usb_validate_langid'
> 
> warning: Excess function parameter 'lang' description in
> 'usb_validate_langid'
> 
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@...il.com>

Hi Daniel,

This is already fixed in Greg's tree.

thanks.

> ---
>  drivers/usb/gadget/usbstring.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/usbstring.c b/drivers/usb/gadget/usbstring.c
> index 58a4d33250902..2e9735abfeb95 100644
> --- a/drivers/usb/gadget/usbstring.c
> +++ b/drivers/usb/gadget/usbstring.c
> @@ -16,7 +16,7 @@
>  
>  
>  /**
> - * usb_gadget_get_string - fill out a string descriptor 
> + * usb_gadget_get_string - fill out a string descriptor
>   * @table: of c strings encoded using UTF-8
>   * @id: string id, from low byte of wValue in get string descriptor
>   * @buf: at least 256 bytes, must be 16-bit aligned
> @@ -68,7 +68,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_get_string);
>  
>  /**
>   * usb_validate_langid - validate usb language identifiers
> - * @lang: usb language identifier
> + * @langid: usb language identifier
>   *
>   * Returns true for valid language identifier, otherwise false.
>   */
> 


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@...radead.org>