linux-kernel - Re: [PATCH 13/25] Documentation: watch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf5f2227-c473-442b-7ad4-5ca3718a6672@infradead.org>
Date:   Fri, 17 Jul 2020 12:42:52 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Daniel W. S. Almeida" <dwlsalmeida@...il.com>, corbet@....net,
        mchehab@...nel.org
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/25] Documentation: watch_queue.rst: fix sphinx warnings

On 7/17/20 11:56 AM, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
> 
> Fix the following warnings:
> 
> watch_queue.rst:107: WARNING: Inline literal start-string
> without end-string.
> 
> watch_queue.rst:107: WARNING: Inline emphasis start-string
> without end-string
> 
> watch_queue.rst:184: WARNING: Inline literal start-string
> without end-string.
> 
> watch_queue.rst:184: WARNING: Inline emphasis start-string
> without end-string
> 
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@...il.com>
> ---
>  Documentation/watch_queue.rst | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/watch_queue.rst b/Documentation/watch_queue.rst
> index 849fad6893efa..4c3098b8fa947 100644
> --- a/Documentation/watch_queue.rst
> +++ b/Documentation/watch_queue.rst
> @@ -103,8 +103,7 @@ watch that specific key).
>  
>  To manage a watch list, the following functions are provided:
>  
> -  * ``void init_watch_list(struct watch_list *wlist,
> -			   void (*release_watch)(struct watch *wlist));``
> +  * ``void init_watch_list(struct watch_list *wlist, void (*release_watch)(struct watch *wlist));``
>  
>      Initialise a watch list.  If ``release_watch`` is not NULL, then this
>      indicates a function that should be called when the watch_list object is
> @@ -179,9 +178,9 @@ The following functions are provided to manage watches:
>      driver-settable fields in the watch struct must have been set before this
>      is called.
>  
> -  * ``int remove_watch_from_object(struct watch_list *wlist,
> -				   struct watch_queue *wqueue,
> -				   u64 id, false);``
> +  * ``int remove_watch_from_object(struct watch_list *wlist,``
> +				 ``struct watch_queue *wqueue,``
> +				 ``u64 id, false);``
>  
>      Remove a watch from a watch list, where the watch must match the specified
>      watch queue (``wqueue``) and object identifier (``id``).  A notification
> 

Wow. If that's what it takes, well, OK, but it's sad IMHO.

-- 
~Randy