linux-kernel - Re: [PATCH] net: smc91x: Fix possible memory leak in smc_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200717.124502.1686970196922612927.davem@davemloft.net>
Date:   Fri, 17 Jul 2020 12:45:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wanghai38@...wei.com
Cc:     nico@...xnic.net, kuba@...nel.org, mst@...hat.com,
        hkallweit1@...il.com, snelson@...sando.io,
        elfring@...rs.sourceforge.net, dmitry.torokhov@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        wanghai26@...wei.com
Subject: Re: [PATCH] net: smc91x: Fix possible memory leak in
 smc_drv_probe()

From: Wang Hai <wanghai38@...wei.com>
Date: Thu, 16 Jul 2020 11:50:38 +0800

> If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev)
> should be called to free the ndev created earlier. Otherwise, a memleak
> will occur.
> 
> Fixes: 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>

Applied, thank you.