linux-kernel - Re: arch/x86/include/asm/preempt.h:79:9: sparse: sparse: context imbalance in 'xfs_iflush_abort'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200717203842.GP7625@magnolia>
Date:   Fri, 17 Jul 2020 13:38:42 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Dave Chinner <dchinner@...hat.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Allison Collins <allison.henderson@...cle.com>,
        Brian Foster <bfoster@...hat.com>
Subject: Re: arch/x86/include/asm/preempt.h:79:9: sparse: sparse: context
 imbalance in 'xfs_iflush_abort' - wrong count at exit

On Mon, Jul 13, 2020 at 11:03:53AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   11ba468877bb23f28956a35e896356252d63c983
> commit: 4165994ac9672d91134675caa6de3645a9ace6c8 xfs: factor common AIL item deletion code
> date:   4 months ago
> config: i386-randconfig-s001-20200713 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
> reproduce:
>         # apt-get install sparse
>         # sparse version: v0.6.2-37-gc9676a3b-dirty
>         git checkout 4165994ac9672d91134675caa6de3645a9ace6c8
>         # save the attached .config to linux build tree
>         make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> arch/x86/include/asm/preempt.h:79:9: sparse: sparse: context imbalance in 'xfs_iflush_abort' - wrong count at exit

Um, does this still need attention?

--D

> vim +/xfs_iflush_abort +79 arch/x86/include/asm/preempt.h
> 
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  72  
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  73  /*
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  74   * The various preempt_count add/sub methods
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  75   */
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  76  
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  77  static __always_inline void __preempt_count_add(int val)
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  78  {
> b3ca1c10d7b32f Christoph Lameter 2014-04-07 @79  	raw_cpu_add_4(__preempt_count, val);
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  80  }
> c2daa3bed53a81 Peter Zijlstra    2013-08-14  81  
> 
> :::::: The code at line 79 was first introduced by commit
> :::::: b3ca1c10d7b32fdfdfaf5484eda486323f52d9be percpu: add raw_cpu_ops
> 
> :::::: TO: Christoph Lameter <cl@...ux.com>
> :::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org