linux-kernel - Re: [PATCH] PCI/ASPM: add missing newline when printing parameter 'policy' by sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Jul 2020 16:36:09 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, guohanjun@...wei.com
Subject: Re: [PATCH] PCI/ASPM: add missing newline when printing parameter
 'policy' by sysfs

On Fri, Jul 17, 2020 at 03:59:25PM +0800, Xiongfeng Wang wrote:
> When I cat ASPM parameter 'policy' by sysfs, it displays as follows.
> It's better to add a newline for easy reading.
> 
> [root@...alhost ~]# cat /sys/module/pcie_aspm/parameters/policy
> [default] performance powersave powersupersave [root@...alhost ~]#
> 
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@...wei.com>

Applied to pci/aspm for v5.9, thanks!

> ---
>  drivers/pci/pcie/aspm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index b17e5ff..253c30c 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -1182,6 +1182,7 @@ static int pcie_aspm_get_policy(char *buffer, const struct kernel_param *kp)
>  			cnt += sprintf(buffer + cnt, "[%s] ", policy_str[i]);
>  		else
>  			cnt += sprintf(buffer + cnt, "%s ", policy_str[i]);
> +	cnt += sprintf(buffer + cnt, "\n");
>  	return cnt;
>  }
>  
> -- 
> 1.7.12.4
>