linux-kernel - Re: [RESEND PATCH 3/4] futex: Remove unused or redundant includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875zalrf03.fsf@nanos.tec.linutronix.de>
Date:   Fri, 17 Jul 2020 23:46:52 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     André Almeida <andrealmeid@...labora.com>,
        linux-kernel@...r.kernel.org, peterz@...radead.org
Cc:     mingo@...hat.com, dvhart@...radead.org, kernel@...labora.com,
        krisman@...labora.com,
        André Almeida <andrealmeid@...labora.com>
Subject: Re: [RESEND PATCH 3/4] futex: Remove unused or redundant includes

André Almeida <andrealmeid@...labora.com> writes:

> Since 82af7aca ("Removal of FUTEX_FD"), some includes related to file
> operations aren't needed anymore. More investigation around the includes
> showed that a lot of includes aren't required for compilation, possible
> due to redundant includes. Simplify the code by removing unused
> includes.
>
> Signed-off-by: André Almeida <andrealmeid@...labora.com>
> ---
> To test this code, I compiled with different configurations (x86_64,
> i386, with x32 ABI supported enabled/disabled), and ran futex
> selftests.

I agree fully with the FD related ones, but are you sure that all of the
others are included on all architectures magically? x86 is just one
piece of the puzzle. We'll see ...