linux-kernel - Re: [PATCH] net: ethernet: ave: Fix error returns in ave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca44d4aa-b65c-adac-334a-85e54816e9e3@socionext.com>
Date:   Fri, 17 Jul 2020 13:16:24 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Wang Hai <wanghai38@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, p.zabel@...gutronix.de,
        yamada.masahiro@...ionext.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ave: Fix error returns in ave_init

Hi Wang,

On 2020/07/17 11:50, Wang Hai wrote:
> When regmap_update_bits failed in ave_init(), calls of the functions
> reset_control_assert() and clk_disable_unprepare() were missed.
> Add goto out_reset_assert to do this.
> 
> Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-mode setting of system controller")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
>   drivers/net/ethernet/socionext/sni_ave.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
> index f2638446b62e..81b554dd7221 100644
> --- a/drivers/net/ethernet/socionext/sni_ave.c
> +++ b/drivers/net/ethernet/socionext/sni_ave.c
> @@ -1191,7 +1191,7 @@ static int ave_init(struct net_device *ndev)
>   	ret = regmap_update_bits(priv->regmap, SG_ETPINMODE,
>   				 priv->pinmode_mask, priv->pinmode_val);
>   	if (ret)
> -		return ret;
> +		goto out_reset_assert;
>   
>   	ave_global_reset(ndev);
>   
> 

Thank you for pointing out.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>

---
Best Regards
Kunihiko Hayashi