linux-kernel - Re: [PATCH][next] i2c: mv64xxx: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878sfi4p51.fsf@FE-laptop>
Date:   Fri, 17 Jul 2020 08:44:10 +0200
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH][next] i2c: mv64xxx: Use fallthrough pseudo-keyword

"Gustavo A. R. Silva" <gustavoars@...nel.org> writes:

> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Reviewed-by: Gregory CLEMENT <gregory.clement@...tlin.com>

> ---
>  drivers/i2c/busses/i2c-mv64xxx.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c
> index 829b8c98ae51..8d9d4ffdcd24 100644
> --- a/drivers/i2c/busses/i2c-mv64xxx.c
> +++ b/drivers/i2c/busses/i2c-mv64xxx.c
> @@ -251,7 +251,7 @@ mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status)
>  				MV64XXX_I2C_STATE_WAITING_FOR_ADDR_2_ACK;
>  			break;
>  		}
> -		/* FALLTHRU */
> +		fallthrough;
>  	case MV64XXX_I2C_STATUS_MAST_WR_ADDR_2_ACK: /* 0xd0 */
>  	case MV64XXX_I2C_STATUS_MAST_WR_ACK: /* 0x28 */
>  		if ((drv_data->bytes_left == 0)
> @@ -282,14 +282,14 @@ mv64xxx_i2c_fsm(struct mv64xxx_i2c_data *drv_data, u32 status)
>  				MV64XXX_I2C_STATE_WAITING_FOR_ADDR_2_ACK;
>  			break;
>  		}
> -		/* FALLTHRU */
> +		fallthrough;
>  	case MV64XXX_I2C_STATUS_MAST_RD_ADDR_2_ACK: /* 0xe0 */
>  		if (drv_data->bytes_left == 0) {
>  			drv_data->action = MV64XXX_I2C_ACTION_SEND_STOP;
>  			drv_data->state = MV64XXX_I2C_STATE_IDLE;
>  			break;
>  		}
> -		/* FALLTHRU */
> +		fallthrough;
>  	case MV64XXX_I2C_STATUS_MAST_RD_DATA_ACK: /* 0x50 */
>  		if (status != MV64XXX_I2C_STATUS_MAST_RD_DATA_ACK)
>  			drv_data->action = MV64XXX_I2C_ACTION_CONTINUE;
> @@ -417,8 +417,7 @@ mv64xxx_i2c_do_action(struct mv64xxx_i2c_data *drv_data)
>  			"mv64xxx_i2c_do_action: Invalid action: %d\n",
>  			drv_data->action);
>  		drv_data->rc = -EIO;
> -
> -		/* FALLTHRU */
> +		fallthrough;
>  	case MV64XXX_I2C_ACTION_SEND_STOP:
>  		drv_data->cntl_bits &= ~MV64XXX_I2C_REG_CONTROL_INTEN;
>  		writel(drv_data->cntl_bits | MV64XXX_I2C_REG_CONTROL_STOP,
> -- 
> 2.27.0
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com