linux-kernel - Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org>
Date:   Fri, 17 Jul 2020 09:56:18 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Frank Lee <tiny.windzz@...il.com>
Cc:     Frank Lee <frank@...winnertech.com>,
        Vasily Khoruzhick <anarsoul@...il.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        黄烁生 <huangshuosheng@...winnertech.com>,
        liyong@...winnertech.com
Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for
 calibration data in sun50i_h6_ths_calibrate

On 17/07/2020 09:35, Frank Lee wrote:
> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
> <daniel.lezcano@...aro.org> wrote:
>>
>> On 14/07/2020 09:13, Frank Lee wrote:
>>> From: Yangtao Li <frank@...winnertech.com>
>>>
>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
>>> calculation. On the other hand, the newer SOC may store other data in
>>> the space other than 12bit sensor data. Add mask operation to read data
>>> to avoid conversion error.
>>>
>>> Signed-off-by: Yangtao Li <frank@...winnertech.com>
>>> Reviewed-by: Yangtao Li <tiny.windzz@...il.com>
>>
>> Can you clarify these SoB ?
> 
> Previously I used 'Signed-off-by: Yangtao Li <tiny.windzz@...il.com>',
> maybe this should be removed directly?
> 
>>
>> Frank Lee==Yangtao Li==frank@...winnertech.com==tiny.windzz@...il.com ?
>>
> 
> Yeah.

You are not supposed to add reviewed-by yourself. Please remove it.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog