linux-kernel - Re: [PATCH] perf evsel: Don't set sample_regs_intr/sample_regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200717082412.GA522549@krava>
Date:   Fri, 17 Jul 2020 10:24:12 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     "Jin, Yao" <yao.jin@...ux.intel.com>
Cc:     Ian Rogers <irogers@...gle.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        LKML <Linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>, kan.liang@...el.com,
        "Jin, Yao" <yao.jin@...el.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH] perf evsel: Don't set sample_regs_intr/sample_regs_user
 for dummy event

On Fri, Jul 17, 2020 at 11:33:46AM +0800, Jin, Yao wrote:
> Hi,
> 
> On 7/6/2020 8:55 AM, Jin, Yao wrote:
> > Hi Ian,
> > 
> > On 7/6/2020 8:47 AM, Ian Rogers wrote:
> > > On Fri, Jul 3, 2020 at 5:31 PM Jin, Yao <yao.jin@...ux.intel.com> wrote:
> > > > 
> > > > Hi Jiri,
> > > > 
> > > > On 7/3/2020 7:00 PM, Jiri Olsa wrote:
> > > > > On Fri, Jul 03, 2020 at 08:42:15AM +0800, Jin Yao wrote:
> > > > > > Since commit 0a892c1c9472 ("perf record: Add dummy event during system wide synthesis"),
> > > > > > a dummy event is added to capture mmaps.
> > > > > > 
> > > > > > But if we run perf-record as,
> > > > > > 
> > > > > >    # perf record -e cycles:p -IXMM0 -a -- sleep 1
> > > > > >    Error:
> > > > > >    dummy:HG: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'
> > > > > > 
> > > 
> > > Sorry for the breakage caused by modifying the dummy event. Could we
> > > add a test to cover the issue? Perhaps in tools/perf/tests/shell/.
> > > Trying to reproduce with a register on my skylakex on a 5.6.14 kernel
> > > with:
> > > 
> > > $ perf record -e cycles:p -IAX -a -- sleep 1
> > > 
> > > succeeds.
> > > 
> > > Thanks,
> > > Ian
> > > 
> > 
> > -IAX should be no problem. The issue only occurs on the platform with
> > extended regs supports, such as ICL. So I don't know if it's suitable to
> > add it to perf test suite.
> > 
> > Thanks
> > Jin Yao
> > 
> 
> Can this fix patch be accepted?

hi,
my only concern was that it would conflict with Adrian's patch,
other than that:

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka