linux-kernel - Re: [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200717083328.GA528602@krava>
Date:   Fri, 17 Jul 2020 10:33:28 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        namhyung@...nel.org, linux-kernel@...r.kernel.org,
        kan.liang@...ux.intel.com, len.brown@...el.com
Subject: Re: [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes

On Thu, Jul 16, 2020 at 11:18:57PM +0800, Zhang Rui wrote:
> This fixes a problem introduced by
> commit 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface")
> that perf event sysfs attributes for psys RAPL domain are missing.
> 
> Fixes: 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface")
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>
> Reviewed-by: Len Brown <len.brown@...el.com>
> ---
>  arch/x86/events/rapl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
> index 0f2bf59f4354..51ff9a3618c9 100644
> --- a/arch/x86/events/rapl.c
> +++ b/arch/x86/events/rapl.c
> @@ -665,7 +665,7 @@ static const struct attribute_group *rapl_attr_update[] = {
>  	&rapl_events_pkg_group,
>  	&rapl_events_ram_group,
>  	&rapl_events_gpu_group,
> -	&rapl_events_gpu_group,
> +	&rapl_events_psys_group,

I did copy & paste but did not change to psys :-\

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

>  	NULL,
>  };
>  
> -- 
> 2.17.1
>