lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Jul 2020 16:44:32 +0800 From: Xiongfeng Wang <wangxiongfeng2@...wei.com> To: <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <john.garry@...wei.com> CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <guohanjun@...wei.com>, <wangxiongfeng2@...wei.com> Subject: [PATCH v2] scsi: scsi_transport_sas: add missing newline when printing 'enable' by sysfs When I cat sysfs file 'enable' below 'sas_phy', it displays as follows. It's better to add a newline for easy reading. [root@...alhost ~]# cat /sys/devices/pci0000:00/0000:00:0d.0/0000:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable 1[root@...alhost ~]# Signed-off-by: Xiongfeng Wang <wangxiongfeng2@...wei.com> Reviewed-by: John Garry <john.garry@...wei.com> --- v1 -> v2: modify commit subject. add Reviewed-by tag. --- drivers/scsi/scsi_transport_sas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 182fd25..e443dee 100644 --- a/drivers/scsi/scsi_transport_sas.c +++ b/drivers/scsi/scsi_transport_sas.c @@ -563,7 +563,7 @@ static ssize_t do_sas_phy_enable(struct device *dev, { struct sas_phy *phy = transport_class_to_phy(dev); - return snprintf(buf, 20, "%d", phy->enabled); + return snprintf(buf, 20, "%d\n", phy->enabled); } static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, show_sas_phy_enable, -- 1.7.12.4
Powered by blists - more mailing lists