linux-kernel - Re: [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3995892c-340c-3419-3c2d-934a3067f51b@collabora.com>
Date:   Fri, 17 Jul 2020 11:53:45 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Rob Herring <robh@...nel.org>,
        Bhanu Prakash Maiya <bhanumaiya@...omium.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Lee Jones <lee.jones@...aro.org>,
        Furquan Shaikh <furquan@...omium.org>,
        Raul E Rangel <rrangel@...omium.org>,
        Eric Peers <epeers@...gle.com>,
        Duncan Laurie <dlaurie@...gle.com>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.Kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: mfd: Add DT compatible string
 "google,cros_ec_uart"

Hi Rob,

On 16/7/20 21:13, Rob Herring wrote:
> On Wed, Jul 15, 2020 at 10:16:04PM -0700, Bhanu Prakash Maiya wrote:
>> From: Bhanu Prakash Maiya <bhanumaiya@...omium.org>
>>
>> Add DT compatible string in
>> Documentation/devicetree/bindings/mfd/cros_ec.txt
> 
> Need to update this.
> 
> With that,
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> 

So this is an ACPI-only driver that is instantiated by using the Device Tree
namespace link in ACPI. I am not sure how to deal with this, but I suspect we
need a proper OF binding definition before accept it.

The driver gets at least the baudrate and the flowcontrol from ACPI resources,
so I'm wondering if we should also add the properties in the device-tree
description (although we're not able to really test because there is not OF
hardware that supports it yet). Or is fine to just accept the compatible for now
and we can do this later when we have the possibility to test with OF-based
hardware.

Rob, any thoughts on this?

Thanks,
  Enric

>> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@...omium.org>
>> ---
>>
>> Changes in v3:
>> - Rebased changes on google,cros-ec.yaml
>>
>> Changes in v2:
>> - No change
>>
>>  Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)