linux-kernel - Re: Re: Re: Re: [PATCH v18 01/14] mm/page_ext: Export lookup_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200717095910.23550-1-sjpark@amazon.com>
Date:   Fri, 17 Jul 2020 11:59:10 +0200
From:   SeongJae Park <sjpark@...zon.com>
To:     SeongJae Park <sjpark@...zon.com>
CC:     Mike Rapoport <rppt@...nel.org>, <akpm@...ux-foundation.org>,
        "SeongJae Park" <sjpark@...zon.de>, <Jonathan.Cameron@...wei.com>,
        <aarcange@...hat.com>, <acme@...nel.org>,
        <alexander.shishkin@...ux.intel.com>, <amit@...nel.org>,
        <benh@...nel.crashing.org>, <brendan.d.gregg@...il.com>,
        <brendanhiggins@...gle.com>, <cai@....pw>,
        <colin.king@...onical.com>, <corbet@....net>, <david@...hat.com>,
        <dwmw@...zon.com>, <foersleo@...zon.de>, <irogers@...gle.com>,
        <jolsa@...hat.com>, <kirill@...temov.name>, <mark.rutland@....com>,
        <mgorman@...e.de>, <minchan@...nel.org>, <mingo@...hat.com>,
        <namhyung@...nel.org>, <peterz@...radead.org>,
        <rdunlap@...radead.org>, <riel@...riel.com>, <rientjes@...gle.com>,
        <rostedt@...dmis.org>, <sblbir@...zon.com>, <shakeelb@...gle.com>,
        <shuah@...nel.org>, <sj38.park@...il.com>, <snu@...zon.de>,
        <vbabka@...e.cz>, <vdavydov.dev@...il.com>,
        <yang.shi@...ux.alibaba.com>, <ying.huang@...el.com>,
        <linux-damon@...zon.com>, <linux-mm@...ck.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: Re: Re: Re: [PATCH v18 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules

On Mon, 13 Jul 2020 19:38:05 +0200 SeongJae Park <sjpark@...zon.com> wrote:

> On Mon, 13 Jul 2020 20:19:09 +0300 Mike Rapoport <rppt@...nel.org> wrote:
> 
> > On Mon, Jul 13, 2020 at 02:21:43PM +0200, SeongJae Park wrote:
> > > On Mon, 13 Jul 2020 15:08:42 +0300 Mike Rapoport <rppt@...nel.org> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > On Mon, Jul 13, 2020 at 10:41:31AM +0200, SeongJae Park wrote:
> > > > > From: SeongJae Park <sjpark@...zon.de>
> > > > > 
> > > > > This commit exports 'lookup_page_ext()' to GPL modules.  It will be used
> > > > > by DAMON in following commit for the implementation of the region based
> > > > > sampling.
> > > > 
> > > > Maybe I'm missing something, but why is DAMON a module?
> > > 
> > > I made it loadable just for easier adoption from downstream kernels.  I could
> > > drop the module build support if asked.
> >  
> > Well, exporting core mm symbols to modules should be considred very
> > carefully. 
> 
> Agreed.  I will drop the module support from the next spin.
> 
> > 
> > Why lookup_page_ext() is required for DAMON? It is not used anywhere in
> > this patchset.
> 
> It's indirectly used.  In the 6th patch, DAMON uses 'set_page_young()' to not
> interfere with other PTE Accessed bit users.  And, 'set_page_young()' uses
> 'lookup_page_ext()' if !CONFIG_64BIT.  That's why I exported it.

This also means that it would make no sense if !64BIT && !PAGE_EXTENSION.  In
the next spin, I will update the DAMON Kconfig to select PAGE_EXTENSION if
!64BIT, as same to that of IDLE_PAGE_TRACKING.


Thanks,
SeongJae Park