linux-kernel - Re: [PATCH 5/5] media/v4l2-subdev.h: drop duplicated word in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Jul 2020 13:00:05 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 5/5] media/v4l2-subdev.h: drop duplicated word in comment

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled words "the" in comments.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: linux-media@...r.kernel.org

I guess the second instance of the word could have also been removed, to
keep more content on the first line, which fits under 80chars, but I
don't think it really matters.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> ---
>  include/media/v4l2-subdev.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> --- linux-next-20200714.orig/include/media/v4l2-subdev.h
> +++ linux-next-20200714/include/media/v4l2-subdev.h
> @@ -566,9 +566,9 @@ struct v4l2_subdev_ir_parameters {
>   *
>   * @rx_read: Reads received codes or pulse width data.
>   *	The semantics are similar to a non-blocking read() call.
> - * @rx_g_parameters: Get the current operating parameters and state of the
> + * @rx_g_parameters: Get the current operating parameters and state of
>   *	the IR receiver.
> - * @rx_s_parameters: Set the current operating parameters and state of the
> + * @rx_s_parameters: Set the current operating parameters and state of
>   *	the IR receiver.  It is recommended to call
>   *	[rt]x_g_parameters first to fill out the current state, and only change
>   *	the fields that need to be changed.  Upon return, the actual device
> @@ -582,9 +582,9 @@ struct v4l2_subdev_ir_parameters {
>   *
>   * @tx_write: Writes codes or pulse width data for transmission.
>   *	The semantics are similar to a non-blocking write() call.
> - * @tx_g_parameters: Get the current operating parameters and state of the
> + * @tx_g_parameters: Get the current operating parameters and state of
>   *	the IR transmitter.
> - * @tx_s_parameters: Set the current operating parameters and state of the
> + * @tx_s_parameters: Set the current operating parameters and state of
>   *	the IR transmitter.  It is recommended to call
>   *	[rt]x_g_parameters first to fill out the current state, and only change
>   *	the fields that need to be changed.  Upon return, the actual device
>