linux-kernel - Re: [PATCH] [PATCH] Firmware security information in SYSFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Jul 2020 16:54:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Daniel Gutson <daniel.gutson@...ypsium.com>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Richard Hughes <hughsient@...il.com>,
        Alex Bazhaniuk <alex@...ypsium.com>
Subject: Re: [PATCH] [PATCH] Firmware security information in SYSFS

On Fri, Jul 17, 2020 at 04:40:40PM +0200, Arnd Bergmann wrote:
> On Fri, Jul 17, 2020 at 8:28 AM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Thu, Jul 16, 2020 at 07:36:27PM -0300, Daniel Gutson wrote:
> > > +What:                /sys/kernel/firmware-security/bioswe
> >
> > Ick, I stopped reading right here.
> >
> > No, this is not where this belongs.
> >
> > We already have /sys/firmware/, right?  And firmware-specific
> > subdirectories below that.
> >
> > We also have /sys/devices/system/ and I think that would be a much
> > better place for this, as it is easier to work with a real 'struct
> > device' than a "raw" kobject any day.  Bonus is you get full support of
> > userspace libraries when you do that, unlike when dealing with kobjects.
> >
> > Also, this really is a _SPECIFIC_ type of firmware that supports these
> > features, right?  Why not call that out too?  This is not generic by any
> > means.
> 
> As I suggested in my previous review, I wouldn't worry too much about
> the user interface at the start, but instead first work out how the hardware
> support fits in with the existing drivers and once that looks fine decide
> on how to export it to user space.
> 
> I agree the  /sys/kernel/firmware-security/bioswe sounds like the wrong
> place, but I'm not sure if adding any other new directory in sysfs is
> much better. I think the most promising would be to have it on the
> sysfs directory for the device it refers to, but let's first see how the
> information gets into the kernel.

Yes, the directory for the specific device would probably be best, but
let's see where that really is :)

thanks,

greg k-h