linux-kernel - Re: [PATCH net] net: macb: use phy_interface_mode_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200717.183254.1462145544224960495.davem@davemloft.net>
Date:   Fri, 17 Jul 2020 18:32:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alexandre.belloni@...tlin.com
Cc:     nicolas.ferre@...rochip.com, kuba@...nel.org, andrew@...n.ch,
        philippe.schenker@...adex.com, linux@...pel-privat.de,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: macb: use phy_interface_mode_is_rgmii
 everywhere

From: Alexandre Belloni <alexandre.belloni@...tlin.com>
Date: Sat, 18 Jul 2020 01:32:21 +0200

> There is one RGMII check not using the phy_interface_mode_is_rgmii()
> helper. This prevents the driver from configuring the MAC properly when
> using a phy-mode that is not just rgmii, e.g. rgmii-rxid. This became an
> issue on sama5d3 xplained since the ksz9031 driver is hadling phy-mode
> properly and the phy-mode has to be set to rgmii-rxid.
> 
> Fixes: bcf3440c6dd78bfe ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Applied, thank you.