linux-kernel - Re: [PATCH 17/30] iio: adc: ad7949: Fix misspelling issue and compiler attribute ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Jul 2020 16:03:14 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Charles-Antoine Couret <charles-antoine.couret@...ensium.com>
Subject: Re: [PATCH 17/30] iio: adc: ad7949: Fix misspelling issue and
 compiler attribute ordering

On Thu, 16 Jul 2020 14:59:15 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> Kerneldoc gets confused if the variable does not follow the
> type/attribute definitions.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/adc/ad7949.c:58: warning: Function parameter or member 'indio_dev' not described in 'ad7949_adc_chip'
>  drivers/iio/adc/ad7949.c:58: warning: Function parameter or member '____cacheline_aligned' not described in 'ad7949_adc_chip'
Holding this one pending discussion of whether to add ___cacheline_aligned to
the stuff kernel-doc effectively skips when processing structures.

Jonathan

> 
> Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> Cc: Charles-Antoine Couret <charles-antoine.couret@...ensium.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/iio/adc/ad7949.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
> index 2c6f60edb7ced..a3fc42617feb9 100644
> --- a/drivers/iio/adc/ad7949.c
> +++ b/drivers/iio/adc/ad7949.c
> @@ -39,7 +39,7 @@ static const struct ad7949_adc_spec ad7949_adc_spec[] = {
>   * struct ad7949_adc_chip - AD ADC chip
>   * @lock: protects write sequences
>   * @vref: regulator generating Vref
> - * @iio_dev: reference to iio structure
> + * @indio_dev: reference to iio structure
>   * @spi: reference to spi structure
>   * @resolution: resolution of the chip
>   * @cfg: copy of the configuration register
> @@ -54,7 +54,7 @@ struct ad7949_adc_chip {
>  	u8 resolution;
>  	u16 cfg;
>  	unsigned int current_channel;
> -	u16 buffer ____cacheline_aligned;
> +	u16 ____cacheline_aligned buffer;
>  };
>  
>  static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val,