linux-kernel - Re: [PATCH 26/30] iio: dac: ad5791: Complete 'struct ad5791_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200718161234.70f19620@archlinux>
Date:   Sat, 18 Jul 2020 16:12:34 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org,
        Michael Hennerich <Michael.Hennerich@...log.com>
Subject: Re: [PATCH 26/30] iio: dac: ad5791: Complete 'struct
 ad5791_chip_info' documentation

On Thu, 16 Jul 2020 14:59:24 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> ... and remove seemingly pointless comment.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'ctrl' not described in 'ad5791_state'
>  drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5791_state'
>  drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'pwr_down' not described in 'ad5791_state'
>  drivers/iio/dac/ad5791.c:97: warning: Function parameter or member 'data' not described in 'ad5791_state'
>  drivers/iio/dac/ad5791.c:103: warning: cannot understand function prototype: 'enum ad5791_supported_device_ids '
> 
> Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ad5791.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c
> index 1d11f39ed0474..d8485004b1010 100644
> --- a/drivers/iio/dac/ad5791.c
> +++ b/drivers/iio/dac/ad5791.c
> @@ -76,9 +76,11 @@ struct ad5791_chip_info {
>   * @chip_info:		chip model specific constants
>   * @vref_mv:		actual reference voltage used
>   * @vref_neg_mv:	voltage of the negative supply
> - * @pwr_down_mode	current power down mode
> + * @ctrl:		control regster cache
> + * @pwr_down_mode:	current power down mode
> + * @pwr_down:		true if device is powered down
> + * @data:		spi transfer buffers
>   */
> -
>  struct ad5791_state {
>  	struct spi_device		*spi;
>  	struct regulator		*reg_vdd;
> @@ -96,10 +98,6 @@ struct ad5791_state {
>  	} data[3] ____cacheline_aligned;
>  };
>  
> -/**
> - * ad5791_supported_device_ids:
> - */
> -
>  enum ad5791_supported_device_ids {
>  	ID_AD5760,
>  	ID_AD5780,