linux-kernel - Re: [PATCH 03/30] iio: adc: twl4030-madc: Fix misnamed struct attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200718163315.631513b0@archlinux>
Date:   Sat, 18 Jul 2020 16:33:15 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, J Keerthy <j-keerthy@...com>,
        Mikko Ylinen <mikko.k.ylinen@...ia.com>,
        Amit Kucheria <amit.kucheria@...onical.com>
Subject: Re: [PATCH 03/30] iio: adc: twl4030-madc: Fix misnamed struct
 attribute

On Fri, 17 Jul 2020 17:55:11 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/adc/twl4030-madc.c:170: warning: Function parameter or member 'usb3v1' not described in 'twl4030_madc_data'
> 
> Cc: J Keerthy <j-keerthy@...com>
> Cc: Mikko Ylinen <mikko.k.ylinen@...ia.com>
> Cc: Amit Kucheria <amit.kucheria@...onical.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Applied with a note that this also cleans up the duplicate docs for lock.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl4030-madc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
> index 826d8295e9b3c..882a678b44690 100644
> --- a/drivers/iio/adc/twl4030-madc.c
> +++ b/drivers/iio/adc/twl4030-madc.c
> @@ -153,7 +153,7 @@ enum sample_type {
>   * struct twl4030_madc_data - a container for madc info
>   * @dev:		Pointer to device structure for madc
>   * @lock:		Mutex protecting this data structure
> - * @regulator:		Pointer to bias regulator for madc
> + * @usb3v1:		Pointer to bias regulator for madc
>   * @requests:		Array of request struct corresponding to SW1, SW2 and RT
>   * @use_second_irq:	IRQ selection (main or co-processor)
>   * @imr:		Interrupt mask register of MADC
> @@ -161,7 +161,7 @@ enum sample_type {
>   */
>  struct twl4030_madc_data {
>  	struct device *dev;
> -	struct mutex lock;	/* mutex protecting this data structure */
> +	struct mutex lock;
>  	struct regulator *usb3v1;
>  	struct twl4030_madc_request requests[TWL4030_MADC_NUM_METHODS];
>  	bool use_second_irq;