linux-kernel - Re: [PATCH 05/30] iio: adc: twl6030-gpadc: Fix some misdocumentation and formatting issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200718163847.51e366fa@archlinux>
Date:   Sat, 18 Jul 2020 16:38:47 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, Stephen Boyd <swboyd@...omium.org>,
        Nishant Kamat <nskamat@...com>, Balaji T K <balajitk@...com>,
        Graeme Gregory <gg@...mlogic.co.uk>,
        Girish S Ghongdemath <girishsg@...com>,
        Ambresh K <ambresh@...com>,
        Oleksandr Kozaruk <oleksandr.kozaruk@...com>,
        Mikko Ylinen <mikko.k.ylinen@...ia.com>
Subject: Re: [PATCH 05/30] iio: adc: twl6030-gpadc: Fix some
 misdocumentation and formatting issues

On Fri, 17 Jul 2020 17:55:13 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> Kerneldoc expects attributes/parameters to be in '@*.: ' format.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'ideal' not described in 'twl6030_gpadc_platform_data'
>  drivers/iio/adc/twl6030-gpadc.c:110: warning: Function parameter or member 'channel_to_reg' not described in 'twl6030_gpadc_platform_data'
> 
> Cc: Stephen Boyd <swboyd@...omium.org>
> Cc: Nishant Kamat <nskamat@...com>
> Cc: Balaji T K <balajitk@...com>
> Cc: Graeme Gregory <gg@...mlogic.co.uk>
> Cc: Girish S Ghongdemath <girishsg@...com>
> Cc: Ambresh K <ambresh@...com>
> Cc: Oleksandr Kozaruk <oleksandr.kozaruk@...com>
> Cc: Mikko Ylinen <mikko.k.ylinen@...ia.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl6030-gpadc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index f24148bd15de4..a19a6ce65e390 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -94,9 +94,9 @@ struct twl6030_gpadc_data;
>   * struct twl6030_gpadc_platform_data - platform specific data
>   * @nchannels:		number of GPADC channels
>   * @iio_channels:	iio channels
> - * @twl6030_ideal:	pointer to calibration parameters
> + * @ideal:		pointer to calibration parameters
>   * @start_conversion:	pointer to ADC start conversion function
> - * @channel_to_reg	pointer to ADC function to convert channel to
> + * @channel_to_reg:	pointer to ADC function to convert channel to
>   *			register address for reading conversion result
>   * @calibrate:		pointer to calibration function
>   */