linux-kernel - Re: [PATCH 09/30] iio: temperature: mlx90632: Function parameter descriptions must match exactly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Jul 2020 16:42:27 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Crt Mori <cmo@...exis.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        linux-arm-kernel@...ts.infradead.org,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Linux Iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 09/30] iio: temperature: mlx90632: Function parameter
 descriptions must match exactly

On Fri, 17 Jul 2020 21:48:06 +0200
Crt Mori <cmo@...exis.com> wrote:

> Acked-by: Crt Mori <cmo@...exis.com>
> 
> On Fri, 17 Jul 2020 at 18:56, Lee Jones <lee.jones@...aro.org> wrote:
> >
> > '*'s are not welcome in kerneldoc parameter names.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/iio/temperature/mlx90632.c:175: warning: Function parameter or member 'data' not described in 'mlx90632_perform_measurement'
> >
> > Cc: Crt Mori <cmo@...exis.com>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
I got lazy on bothering about the addition of optional brackets.

Applied,

Thanks,

Jonathan

> > ---
> >  drivers/iio/temperature/mlx90632.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> > index eaca6ba068646..b9a8089be3f63 100644
> > --- a/drivers/iio/temperature/mlx90632.c
> > +++ b/drivers/iio/temperature/mlx90632.c
> > @@ -164,8 +164,8 @@ static s32 mlx90632_pwr_continuous(struct regmap *regmap)
> >  }
> >
> >  /**
> > - * mlx90632_perform_measurement - Trigger and retrieve current measurement cycle
> > - * @*data: pointer to mlx90632_data object containing regmap information
> > + * mlx90632_perform_measurement() - Trigger and retrieve current measurement cycle
> > + * @data: pointer to mlx90632_data object containing regmap information
> >   *
> >   * Perform a measurement and return latest measurement cycle position reported
> >   * by sensor. This is a blocking function for 500ms, as that is default sensor
> > --
> > 2.25.1
> >