lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Jul 2020 16:52:19 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Lee Jones <lee.jones@...aro.org> Cc: knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org, Michael Hennerich <Michael.Hennerich@...log.com> Subject: Re: [PATCH 17/30] iio: gyro: adxrs450: Change ordering of compiler attribute macro On Fri, 17 Jul 2020 17:55:25 +0100 Lee Jones <lee.jones@...aro.org> wrote: > Kerneldoc gets confused if the variable does not follow the > type/attribute definitions. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/gyro/adxrs450.c:79: warning: Function parameter or member '____cacheline_aligned' not described in 'adxrs450_state' > > Cc: Michael Hennerich <Michael.Hennerich@...log.com> > Signed-off-by: Lee Jones <lee.jones@...aro.org> Holding this one for the conversation about whether we should be fixing the code or the tool. Thanks, Jonathan > --- > drivers/iio/gyro/adxrs450.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/gyro/adxrs450.c b/drivers/iio/gyro/adxrs450.c > index b00c0eb442493..e00b97e30cf9d 100644 > --- a/drivers/iio/gyro/adxrs450.c > +++ b/drivers/iio/gyro/adxrs450.c > @@ -73,7 +73,7 @@ enum { > struct adxrs450_state { > struct spi_device *us; > struct mutex buf_lock; > - __be32 tx ____cacheline_aligned; > + __be32 ____cacheline_aligned tx; > __be32 rx; > > };
Powered by blists - more mailing lists