linux-kernel - Re: [PATCH 21/30] iio: adc: max9611: Demote obvious misuse of kerneldoc to standard comment blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Jul 2020 16:59:50 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH 21/30] iio: adc: max9611: Demote obvious misuse of
 kerneldoc to standard comment blocks

On Fri, 17 Jul 2020 17:55:29 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> No attempt has been made to document any of the demoted structs here.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/adc/max9611.c:117: warning: cannot understand function prototype: 'const unsigned int max9611_mux_conf[][2] = '
>  drivers/iio/adc/max9611.c:145: warning: cannot understand function prototype: 'const unsigned int max9611_gain_conf[][2] = '
> 
> Cc: Jacopo Mondi <jacopo+renesas@...ndi.org>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Applied

Thanks,

Jonathan

> ---
>  drivers/iio/adc/max9611.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
> index 04d5ff7d2c8ec..3a361299a70f4 100644
> --- a/drivers/iio/adc/max9611.c
> +++ b/drivers/iio/adc/max9611.c
> @@ -110,7 +110,7 @@ enum max9611_conf_ids {
>  	CONF_TEMP,
>  };
>  
> -/**
> +/*
>   * max9611_mux_conf - associate ADC mux configuration with register address
>   *		      where data shall be read from
>   */
> @@ -133,7 +133,7 @@ enum max9611_csa_gain_params {
>  	CSA_GAIN_OFFS_RAW,
>  };
>  
> -/**
> +/*
>   * max9611_csa_gain_conf - associate gain multiplier with LSB and
>   *			   offset values.
>   *