linux-kernel - Re: [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Jul 2020 17:15:36 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Heiko Stübner <heiko@...ech.de>
Cc:     Lee Jones <lee.jones@...aro.org>, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote
 seemingly unintentional kerneldoc header

On Fri, 17 Jul 2020 21:10:27 +0200
Heiko Stübner <heiko@...ech.de> wrote:

> Am Freitag, 17. Juli 2020, 18:55:38 CEST schrieb Lee Jones:
> > This is the only use of kerneldoc in the source file and no
> > descriptions are provided.
> > 
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/iio/adc/rockchip_saradc.c:190: warning: Function parameter or member 'reset' not described in 'rockchip_saradc_reset_controller'
> > 
> > Cc: Heiko Stuebner <heiko@...ech.de>
> > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > Cc: linux-rockchip@...ts.infradead.org
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>  
> 
> Subject-line says "Demote Demote..."
> 
> Otherwise
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
Fixed up and applied.

Thanks for whole set Lee.

Jonathan

> 
> 
> > ---
> >  drivers/iio/adc/rockchip_saradc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> > index 582ba047c4a67..cf4ec59c1dab0 100644
> > --- a/drivers/iio/adc/rockchip_saradc.c
> > +++ b/drivers/iio/adc/rockchip_saradc.c
> > @@ -183,7 +183,7 @@ static const struct of_device_id rockchip_saradc_match[] = {
> >  };
> >  MODULE_DEVICE_TABLE(of, rockchip_saradc_match);
> >  
> > -/**
> > +/*
> >   * Reset SARADC Controller.
> >   */
> >  static void rockchip_saradc_reset_controller(struct reset_control *reset)
> >   
> 
> 
> 
>