linux-kernel - RE: [PATCH] iio: trigger: Staticise stub functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR03MB4411D0B8239819F58B33F7BCF97D0@DM6PR03MB4411.namprd03.prod.outlook.com>
Date:   Sat, 18 Jul 2020 17:10:16 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     Lars-Peter Clausen <lars@...afoo.de>,
        Jonathan Cameron <jic23@...nel.org>
CC:     "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: trigger: Staticise stub functions

Apologies from my side for being too much of a patch-bot here.
I should have also given some more thought to the patch.
Atm, I'm sending this from Outlook, since [for some reason] the Linux mail-client isn't working.
[ Which is why this isn't properly inlined either ]

I'll send a V2.

-----Original Message-----
From: Lars-Peter Clausen <lars@...afoo.de> 
Sent: Saturday, July 18, 2020 7:37 PM
To: Jonathan Cameron <jic23@...nel.org>; Ardelean, Alexandru <alexandru.Ardelean@...log.com>
Cc: linux-iio@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: trigger: Staticise stub functions

[External]

On 7/18/20 6:25 PM, Jonathan Cameron wrote:
> On Tue, 14 Jul 2020 17:24:56 +0300
> Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:
>
>> From: Lars-Peter Clausen <lars@...afoo.de>
>>
>> Make sure that the trigger function stubs are all static inline. 
>> Otherwise we'll get linker errors due to multiple definitions of the same function.
>>
>> Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> I'm curious on what the actual build error is?  Static functions 
> should result in independent implementations in each C file that 
> includes them. Inline is normally considered a hint.  Hence what am I missing?

It's a bad commit message, my fault. This should have been

Make sure that the trigger function stubs are all static inline. 
Otherwise we might see compiler warnings about declared but unused functions.