| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202007190114.WmdAF8Tz%lkp@intel.com>
Date: Sun, 19 Jul 2020 02:00:12 +0800
From: kernel test robot <lkp@...el.com>
To: B K Karthik <bkkarthik@...u.pes.edu>,
Larry Finger <Larry.Finger@...inger.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Michael Straube <straube.linux@...il.com>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH 3/4] staging: rtl8188eu: include: enclosed macros in
do-while loops
Hi K,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/B-K-Karthik/staging-rtl8188eu-include-fixed-multiple-blank-space-coding-style-issues/20200718-172103
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 9d5d041eebe3dcf7591ff7004896c329eb841ca6
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ed6b578040a85977026c93bf4188f996148f3218)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
In file included from drivers/staging/rtl8188eu/core/rtw_sreset.c:8:
In file included from drivers/staging/rtl8188eu/include/rtw_sreset.h:17:
In file included from drivers/staging/rtl8188eu/include/rtl8188e_hal.h:21:
In file included from drivers/staging/rtl8188eu/include/odm_precomp.h:26:
>> drivers/staging/rtl8188eu/include/odm_debug.h:80:3: error: expected identifier or '('
if (((comp) & pDM_Odm->DebugComponents) && \
^
>> drivers/staging/rtl8188eu/include/odm_debug.h:85:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:85:4: error: expected identifier or '('
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:4: error: expected identifier or '('
} while (0)
^
5 errors generated.
--
In file included from drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:6:
In file included from drivers/staging/rtl8188eu/include/odm_precomp.h:26:
>> drivers/staging/rtl8188eu/include/odm_debug.h:80:3: error: expected identifier or '('
if (((comp) & pDM_Odm->DebugComponents) && \
^
>> drivers/staging/rtl8188eu/include/odm_debug.h:85:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:85:4: error: expected identifier or '('
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:4: error: expected identifier or '('
} while (0)
^
>> drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:109:1: error: expected 'while' in do/while loop
static int odm_RateDown_8188E(struct odm_dm_struct *dm_odm,
^
drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:105:2: note: to match this 'do'
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:761:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:86:1: note: to match this '{'
{
^
7 errors generated.
--
In file included from drivers/staging/rtl8188eu/hal/odm.c:8:
In file included from drivers/staging/rtl8188eu/include/odm_precomp.h:26:
>> drivers/staging/rtl8188eu/include/odm_debug.h:80:3: error: expected identifier or '('
if (((comp) & pDM_Odm->DebugComponents) && \
^
>> drivers/staging/rtl8188eu/include/odm_debug.h:85:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:85:4: error: expected identifier or '('
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:4: error: expected identifier or '('
} while (0)
^
>> drivers/staging/rtl8188eu/hal/odm.c:150:6: warning: no previous prototype for function 'ODM_InitDebugSetting' [-Wmissing-prototypes]
void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm)
^
drivers/staging/rtl8188eu/hal/odm.c:150:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm)
^
static
>> drivers/staging/rtl8188eu/hal/odm.c:268:1: error: expected 'while' in do/while loop
void odm_CmnInfoHook_Debug(struct odm_dm_struct *pDM_Odm)
^
drivers/staging/rtl8188eu/hal/odm.c:265:2: note: to match this 'do'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("bDualMacSmartConcurrent=%d\n", pDM_Odm->bDualMacSmartConcurrent));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm.c:264:2: note: to match this '{'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("bWIFITest=%d\n", pDM_Odm->bWIFITest));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected 'while' in do/while loop
}
^
drivers/staging/rtl8188eu/hal/odm.c:264:2: note: to match this 'do'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("bWIFITest=%d\n", pDM_Odm->bWIFITest));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm.c:263:2: note: to match this '{'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("bInHctTest=%d\n", pDM_Odm->bInHctTest));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected 'while' in do/while loop
}
^
drivers/staging/rtl8188eu/hal/odm.c:263:2: note: to match this 'do'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("bInHctTest=%d\n", pDM_Odm->bInHctTest));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm.c:262:2: note: to match this '{'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("PatchID=%d\n", pDM_Odm->PatchID));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected 'while' in do/while loop
}
^
drivers/staging/rtl8188eu/hal/odm.c:262:2: note: to match this 'do'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("PatchID=%d\n", pDM_Odm->PatchID));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm.c:261:2: note: to match this '{'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("ExtTRSW=%d\n", pDM_Odm->ExtTRSW));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected 'while' in do/while loop
}
^
drivers/staging/rtl8188eu/hal/odm.c:261:2: note: to match this 'do'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("ExtTRSW=%d\n", pDM_Odm->ExtTRSW));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm.c:260:2: note: to match this '{'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("ExtPA=%d\n", pDM_Odm->ExtPA));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected 'while' in do/while loop
}
^
drivers/staging/rtl8188eu/hal/odm.c:260:2: note: to match this 'do'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("ExtPA=%d\n", pDM_Odm->ExtPA));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm.c:259:2: note: to match this '{'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("ExtLNA=%d\n", pDM_Odm->ExtLNA));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected 'while' in do/while loop
}
^
drivers/staging/rtl8188eu/hal/odm.c:259:2: note: to match this 'do'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("ExtLNA=%d\n", pDM_Odm->ExtLNA));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm.c:1100:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm.c:258:2: note: to match this '{'
ODM_RT_TRACE(pDM_Odm, ODM_COMP_COMMON, ODM_DBG_LOUD, ("BoardType=%d\n", pDM_Odm->BoardType));
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.
--
In file included from drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:8:
In file included from drivers/staging/rtl8188eu/include/odm_precomp.h:26:
>> drivers/staging/rtl8188eu/include/odm_debug.h:80:3: error: expected identifier or '('
if (((comp) & pDM_Odm->DebugComponents) && \
^
>> drivers/staging/rtl8188eu/include/odm_debug.h:85:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:85:4: error: expected identifier or '('
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:4: error: expected identifier or '('
} while (0)
^
>> drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:323:3: error: expected 'while' in do/while loop
return;
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:313:4: note: to match this 'do'
ODM_RT_TRACE(dm_odm, ODM_COMP_ANT_DIV, ODM_DBG_LOUD,
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:338:2: error: expected 'while' in do/while loop
if ((dm_odm->AntDivType == CG_TRX_HW_ANTDIV) ||
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:327:3: note: to match this 'do'
ODM_RT_TRACE(dm_odm, ODM_COMP_ANT_DIV, ODM_DBG_LOUD,
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:341:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:310:3: note: to match this '{'
ODM_RT_TRACE(dm_odm, ODM_COMP_ANT_DIV, ODM_DBG_LOUD,
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:5: note: expanded from macro 'ODM_RT_TRACE'
do {
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:341:2: error: expected 'while' in do/while loop
}
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:310:3: note: to match this 'do'
ODM_RT_TRACE(dm_odm, ODM_COMP_ANT_DIV, ODM_DBG_LOUD,
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:341:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:309:24: note: to match this '{'
if (!dm_odm->bLinked) {
^
>> drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:341:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/odm_rtl8188e.c:302:1: note: to match this '{'
{
^
11 errors generated.
--
In file included from drivers/staging/rtl8188eu/hal/rtl8188e_dm.c:19:
In file included from drivers/staging/rtl8188eu/include/rtl8188e_hal.h:21:
In file included from drivers/staging/rtl8188eu/include/odm_precomp.h:26:
>> drivers/staging/rtl8188eu/include/odm_debug.h:80:3: error: expected identifier or '('
if (((comp) & pDM_Odm->DebugComponents) && \
^
>> drivers/staging/rtl8188eu/include/odm_debug.h:85:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:85:4: error: expected identifier or '('
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:4: error: expected identifier or '('
} while (0)
^
>> drivers/staging/rtl8188eu/hal/rtl8188e_dm.c:172:2: error: implicit declaration of function 'ODM_InitDebugSetting' [-Werror,-Wimplicit-function-declaration]
ODM_InitDebugSetting(podmpriv);
^
6 errors generated.
--
In file included from drivers/staging/rtl8188eu/hal/phy.c:11:
In file included from drivers/staging/rtl8188eu/include/rtl8188e_hal.h:21:
In file included from drivers/staging/rtl8188eu/include/odm_precomp.h:26:
>> drivers/staging/rtl8188eu/include/odm_debug.h:80:3: error: expected identifier or '('
if (((comp) & pDM_Odm->DebugComponents) && \
^
>> drivers/staging/rtl8188eu/include/odm_debug.h:85:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:85:4: error: expected identifier or '('
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:2: error: extraneous closing brace ('}')
} while (0)
^
drivers/staging/rtl8188eu/include/odm_debug.h:96:4: error: expected identifier or '('
} while (0)
^
>> drivers/staging/rtl8188eu/hal/phy.c:321:4: error: expected 'while' in do/while loop
} else if (type == 1) { /* For CCK adjust. */
^
drivers/staging/rtl8188eu/hal/phy.c:307:3: note: to match this 'do'
ODM_RT_TRACE(dm_odm, ODM_COMP_TX_PWR_TRACK, ODM_DBG_LOUD,
^
drivers/staging/rtl8188eu/include/odm_debug.h:79:2: note: expanded from macro 'ODM_RT_TRACE'
do {
^
>> drivers/staging/rtl8188eu/hal/phy.c:1335:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/phy.c:306:17: note: to match this '{'
if (type == 0) { /* For OFDM adjust */
^
>> drivers/staging/rtl8188eu/hal/phy.c:1335:2: error: expected '}'
}
^
drivers/staging/rtl8188eu/hal/phy.c:303:1: note: to match this '{'
{
^
8 errors generated.
vim +80 drivers/staging/rtl8188eu/include/odm_debug.h
f9f08d70b0081c Larry Finger 2013-08-21 77
f9f08d70b0081c Larry Finger 2013-08-21 78 #define ODM_RT_TRACE(pDM_Odm, comp, level, fmt) \
14200067aff819 B K Karthik 2020-07-18 79 do {
f9f08d70b0081c Larry Finger 2013-08-21 @80 if (((comp) & pDM_Odm->DebugComponents) && \
f9f08d70b0081c Larry Finger 2013-08-21 81 (level <= pDM_Odm->DebugLevel)) { \
c9e27530b25fd8 Mahati Chamarthy 2014-10-04 82 pr_info("[ODM-8188E] "); \
f9f08d70b0081c Larry Finger 2013-08-21 83 RT_PRINTK fmt; \
f9f08d70b0081c Larry Finger 2013-08-21 84 }
14200067aff819 B K Karthik 2020-07-18 @85 } while (0)
f9f08d70b0081c Larry Finger 2013-08-21 86
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (75379 bytes)
Powered by blists - more mailing lists