linux-kernel - Re: [PATCH] habanalabs: use no flags on MMU cache invalidation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 19 Jul 2020 11:10:21 +0300
From:   Oded Gabbay <oded.gabbay@...il.com>
To:     Tomer Tayar <ttayar@...ana.ai>
Cc:     "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        SW_Drivers@...ana.ai
Subject: Re: [PATCH] habanalabs: use no flags on MMU cache invalidation

On Sun, Jul 19, 2020 at 11:00 AM Tomer Tayar <ttayar@...ana.ai> wrote:
>
> gaudi_mmu_invalidate_cache() doesn't use the flags parameter, and thus
> it can be set to 0 when the function is called in the gaudi only files.
>
> Signed-off-by: Tomer Tayar <ttayar@...ana.ai>
> ---
>  drivers/misc/habanalabs/gaudi/gaudi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
> index 86cfaf73ad74..4a1a52608fc0 100644
> --- a/drivers/misc/habanalabs/gaudi/gaudi.c
> +++ b/drivers/misc/habanalabs/gaudi/gaudi.c
> @@ -2646,8 +2646,7 @@ static int gaudi_mmu_init(struct hl_device *hdev)
>         WREG32(mmSTLB_CACHE_INV_BASE_39_8, MMU_CACHE_MNG_ADDR >> 8);
>         WREG32(mmSTLB_CACHE_INV_BASE_49_40, MMU_CACHE_MNG_ADDR >> 40);
>
> -       hdev->asic_funcs->mmu_invalidate_cache(hdev, true,
> -                                       VM_TYPE_USERPTR | VM_TYPE_PHYS_PACK);
> +       hdev->asic_funcs->mmu_invalidate_cache(hdev, true, 0);
>
>         WREG32(mmMMU_UP_MMU_ENABLE, 1);
>         WREG32(mmMMU_UP_SPI_MASK, 0xF);
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@...il.com>