linux-kernel - Re: [PATCH 2/2] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pn8reei7.fsf@tarshish>
Date:   Sun, 19 Jul 2020 18:00:32 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     miguelborgesdefreitas@...il.com
Cc:     a.zummo@...ertech.it, devicetree@...r.kernel.org,
        alexandre.belloni@...tlin.com, festevam@...il.com,
        s.hauer@...gutronix.de, linux@...linux.org.uk,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        linux-imx@....com, kernel@...gutronix.de, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC

Hi Miguel,

On Sun, Jul 19 2020, miguelborgesdefreitas@...il.com wrote:
> From: Miguel Borges de Freitas <miguelborgesdefreitas@...il.com>
>
> Signed-off-by: Miguel Borges de Freitas <miguelborgesdefreitas@...il.com>
> ---

The commit log should explain why you enable this for Cubox-i. The
information is in your cover letter. But the cover letter is not
preserved in the git commit log history.

Thanks,
baruch

>  arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index e3be453..a226c4e 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -144,6 +144,7 @@
>  	rtc@68 {
>  		compatible = "nxp,pcf8523";
>  		reg = <0x68>;
> +		pm-enable-dsm;
>  	};
>  };


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -