linux-kernel - Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200719165746.GJ2786714@ZenIV.linux.org.uk>
Date:   Sun, 19 Jul 2020 17:57:46 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     "Xu, Yanfei" <yanfei.xu@...driver.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] userfaultfd: avoid the duplicated release for
 userfaultfd_ctx

On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote:
> ping Al Viro
> 
> Could you please help to review this patch? Thanks a lot.

That's -next, right?  As for the patch itself...  Frankly,
Daniel's patch looks seriously wrong.
	* why has O_CLOEXEC been quietly smuggled in?  It's
a userland ABI change, for fsck sake...
	* the double-put you've spotted
	* the whole out: thing - just make it
	if (IS_ERR(file)) {
		userfaultfd_ctx_put(ctx);
		return PTR_ERR(file);
	}
	and be done with that.