linux-kernel - Re: 5.8-rc*: kernel BUG at kernel/signal.c:1917

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200719182304.GB28397@redhat.com>
Date:   Sun, 19 Jul 2020 20:23:05 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Christian Brauner <christian.brauner@...ntu.com>,
        Jiri Slaby <jirislaby@...nel.org>, christian@...uner.io,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        Markus Elfring <Markus.Elfring@....de>
Subject: Re: 5.8-rc*: kernel BUG at kernel/signal.c:1917

Hi Hillf,

On 07/19, Hillf Danton wrote:
>
> Dunno if the wheel prior to JOBCTL_TASK_WORK helps debug the warnings.
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2541,7 +2541,7 @@ bool get_signal(struct ksignal *ksig)
>
>  relock:
>  	spin_lock_irq(&sighand->siglock);
> -	current->jobctl &= ~JOBCTL_TASK_WORK;
> +	task_clear_jobctl_pending(current, JOBCTL_TASK_WORK);
>  	if (unlikely(current->task_works)) {
>  		spin_unlock_irq(&sighand->siglock);
>  		task_work_run();
> --- a/kernel/task_work.c
> +++ b/kernel/task_work.c
> @@ -43,8 +43,8 @@ task_work_add(struct task_struct *task,
>  		break;
>  	case TWA_SIGNAL:
>  		if (lock_task_sighand(task, &flags)) {
> -			task->jobctl |= JOBCTL_TASK_WORK;
> -			signal_wake_up(task, 0);
> +			if (task_set_jobctl_pending(task, JOBCTL_TASK_WORK))
> +				recalc_sigpending_and_wake(task);
>  			unlock_task_sighand(task, &flags);

To be be honest I don't understand why do you think this makes any sense...

But this doesn't matter, please note that the Jiri tested the kernel with
e91b48162332480f5 (which added JOBCTL_TASK_WORK) reverted.

Oleg.