linux-kernel - Re: [PATCH] rculist: Silence unused-value warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200719184213.GJ9247@paulmck-ThinkPad-P72>
Date:   Sun, 19 Jul 2020 11:42:13 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Suraj Upadhyay <usuraj35@...il.com>
Cc:     josh@...htriplett.org, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        joel@...lfernandes.org, madhuparnabhowmik10@...il.com,
        rcu@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rculist: Silence unused-value warning.

On Sun, Jul 19, 2020 at 10:53:05PM +0530, Suraj Upadhyay wrote:
> On Sun 19 Jul, 2020, 21:37 Paul E. McKenney, <paulmck@...nel.org> wrote:
> 
> > On Sun, Jul 19, 2020 at 04:20:37PM +0530, Suraj Upadhyay wrote:
> > > The macro __list_check_srcu is used as a statement inside a for loop.
> > >
> > > __list_check_srcu becomes "true" when CONFIG_PROVE_RCU_LIST is not
> > defined.
> > > This results in compiler warning about an unused value ("true").
> > >
> > > Silence the compiler warning about the unused value "true"
> > > by replacing it with an empty expression.
> > >
> > > Signed-off-by: Suraj Upadhyay <usuraj35@...il.com>
> >
> > Like this, you mean, give or take whitespace?  ;-)
> >
> > https://lore.kernel.org/lkml/20200718001259.GY9247@paulmck-ThinkPad-P72/
> >
> > May I add your Tested-by?
> >
> >                                                         Thanx, Paul
> >
> 
> Yeah sure.

Thank you, I have applied it and it will be public on my next rebase.
And thank you for your testing efforts!

							Thanx, Paul

> Thanks,
> 
> Suraj Upadhyay.
> 
> > ---
> > >  include/linux/rculist.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/rculist.h b/include/linux/rculist.h
> > > index de9385b9158e..8b8e0584c473 100644
> > > --- a/include/linux/rculist.h
> > > +++ b/include/linux/rculist.h
> > > @@ -73,7 +73,7 @@ static inline void INIT_LIST_HEAD_RCU(struct list_head
> > *list)
> > >  #define __list_check_rcu(dummy, cond, extra...)
> >       \
> > >       ({ check_arg_count_one(extra); })
> > >
> > > -#define __list_check_srcu(cond) true
> > > +#define __list_check_srcu(cond) ({})
> > >  #endif
> > >
> > >  /*
> > > --
> > > 2.17.1
> > >
> >
> >
> >