linux-kernel - RE: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HK2PR01MB32812019FB4521DC22313B10FA7B0@HK2PR01MB3281.apcprd01.prod.exchangelabs.com>
Date:   Mon, 20 Jul 2020 03:46:15 +0000
From:   Johnson CH Chen (陳昭勳) 
        <JohnsonCH.Chen@...a.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Randy Dunlap <rdunlap@...radead.org>
CC:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Scott Wood <scottwood@...escale.com>
Subject: RE: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

Hi Stephen, 

> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Sent: Saturday, July 18, 2020 9:39 AM
> To: Randy Dunlap <rdunlap@...radead.org>
> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>; Linux Kernel Mailing
> List <linux-kernel@...r.kernel.org>; linux-rtc@...r.kernel.org; Alessandro
> Zummo <a.zummo@...ertech.it>; Alexandre Belloni
> <alexandre.belloni@...tlin.com>; Scott Wood <scottwood@...escale.com>;
> Johnson CH Chen (陳昭勳) <JohnsonCH.Chen@...a.com>
> Subject: Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)
> 
> Hi Randy,
> 
> [Please trim your emails a bit more, thanks]
> 
> On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap <rdunlap@...radead.org>
> wrote:
> > on x86_64:
> > # CONFIG_WATCHDOG is not set
> >

Thanks for your information.

It seems RTC_DRV_DS1374_WDT should be depended on RTC_DRV_DS1374 && WATCHDOG_CORE. Otherwise error will happen if RTC_DRV_DS1374_WDT is enabled but WATCHDOG_CORE not. I'll put this into v5 if there are no other suggestions.

Should I add " Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>" into v5? So many thanks!

> > ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe':
> > rtc-ds1374.c:(.text+0x736): undefined reference to
> `watchdog_init_timeout'
> > ld: rtc-ds1374.c:(.text+0x77e): undefined reference to
> `devm_watchdog_register_device'
> 
> Caused by commit
> 
>   d3de4beb14a8 ("rtc: ds1374: wdt: Use watchdog core for watchdog
> part")
> 
> from the rtc tree.
> --
> Cheers,
> Stephen Rothwell

Best regards,
Johnson