linux-kernel - Re: [PATCH v9 1/2] dt-bindings: timer: Add Ingenic X1000 OST bindings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 10:33:49 -0600
From:   Rob Herring <robh@...nel.org>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>
Cc:     yanfei.li@...enic.com, devicetree@...r.kernel.org,
        dongsheng.qiu@...enic.com, zhenwenjin@...il.com,
        aric.pzqi@...enic.com, paul@...pouillou.net,
        rick.tyliu@...enic.com, daniel.lezcano@...aro.org,
        tglx@...utronix.de, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, sernia.zhou@...mail.com
Subject: Re: [PATCH v9 1/2] dt-bindings: timer: Add Ingenic X1000 OST
 bindings.

On Mon, 20 Jul 2020 23:11:05 +0800, 周琰杰 (Zhou Yanjie) wrote:
> Add the OST bindings for the X10000 SoC from Ingenic.
> 
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@...mail.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> Reviewed-by: Paul Cercueil <paul@...pouillou.net>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---
> 
> Notes:
>     v1->v2:
>     No change.
> 
>     v2->v3:
>     Fix wrong parameters in "clocks".
> 
>     v3->v4:
>     1.Rename "ingenic,ost.yaml" to "ingenic,sysost.yaml".
>     2.Rename "ingenic,ost.h" to "ingenic,sysost.h".
>     3.Modify the description in "ingenic,sysost.yaml".
> 
>     v4->v5:
>     No change.
> 
>     v5->v6:
>     1.Drop "oneOf" and the blank line.
>     2.Add "additionalProperties: false".
> 
>     v6->v7:
>     No change.
> 
>     v7->v8:
>     No change.
> 
>     v8->v9:
>     Fix warning while applying.
>     Reported-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> 
>  .../devicetree/bindings/timer/ingenic,sysost.yaml  | 63 ++++++++++++++++++++++
>  include/dt-bindings/clock/ingenic,sysost.h         | 12 +++++
>  2 files changed, 75 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
>  create mode 100644 include/dt-bindings/clock/ingenic,sysost.h
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml: properties: '#address-cells' is a dependency of '#size-cells'
Documentation/devicetree/bindings/Makefile:20: recipe for target 'Documentation/devicetree/bindings/timer/ingenic,sysost.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/timer/ingenic,sysost.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml: ignoring, error in schema: properties
warning: no schema found in file: ./Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml: ignoring, error in schema: properties
warning: no schema found in file: ./Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
Makefile:1347: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1332465

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.